Squelch deprecation warning #1833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most recent CMake started complaining about the pending end of 3.8 support. > ``` > CMake Deprecation Warning at CMakeLists.txt:4 (cmake_minimum_required): > Compatibility with CMake < 3.10 will be removed from a future version of > CMake. > > Update the VERSION argument <min> value. Or, use the <min>...<max> syntax > to tell CMake that the project requires at least <min> but has been updated > to work with policies introduced by <max> or earlier. > ``` We can retain support by adding a max version. This will no prevent use with newer versions, but indicates forward compatibility.[^1] [^1]: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html
Contributor
|
Why not use CMake > 3.8? 3.8 was released 2018 and there's barely a reason to stay on such an old version. |
Contributor
Author
I considered that, but we're not using anything that requires anything newer, and this is easy enough to fix without breaking compatibility. I agree, however, that we should not hesitate to bump the minimum version if we ever want a newer CMake behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most recent CMake started complaining about the pending end of 3.8 support.
We can retain support by adding a max version. This will not prevent use with newer versions, but indicates forward compatibility.1
Footnotes
https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html ↩