DynamoDB and MongoDB: Fix CI and improve decoding #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
058b1a1 to
034dc0d
Compare
amotl
commented
Oct 9, 2024
Comment on lines
-13
to
+22
| def cratedb(cratedb_service): | ||
| def cratedb_custom_service(): | ||
| """ | ||
| Provide a CrateDB service instance to the test suite. | ||
| """ | ||
| from cratedb_toolkit.testing.testcontainers.cratedb import CrateDBTestAdapter | ||
|
|
||
| db = CrateDBTestAdapter(crate_version="5.8.3") | ||
| db.start() | ||
| yield db | ||
| db.stop() |
There was a problem hiding this comment.
Needed to downgrade to CrateDB 5.8.3 in order to satisfy CI.
... because 5.8.4 can no longer store `ARRAY`s with varying inner types into `OBJECT(IGNORED)` columns.
034dc0d to
4efcdcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About