Skip to content

Conversation

@danpawlik
Copy link
Collaborator

@danpawlik danpawlik commented Sep 5, 2025

Previous sha checksum is not available anymore.

Summary by CodeRabbit

  • Chores
    • Updated final-stage base container image to a newer CentOS Stream 9 release to pick up upstream patches and security fixes.
    • Increased CI linting timeout to improve build stability; minor whitespace normalization in linter config.
    • No user-facing functionality changes; runtime behavior remains unchanged.

@coderabbitai
Copy link

coderabbitai bot commented Sep 5, 2025

Walkthrough

Updated the final-stage base image digest in oci/Containerfile and increased run.timeout in .golangci.yml (from 10m to 15m); a minor whitespace normalization in .golangci.yml was also applied. No exported/public declarations changed.

Changes

Cohort / File(s) Summary
Container base image update
oci/Containerfile
Updated final-stage base image digest from quay.io/centos/centos:stream9@sha256:5e9069a89b1766ca979f0bf6eafcd4e3725adb9e873776a80ade285c65aa4fb7 to quay.io/centos/centos:stream9@sha256:a2ef206db47cea339ec3b6b0f3b5f4ebf2b6888a4a62746c4c5978bdfe015b32. All other instructions unchanged.
CI lint config tweak
.golangci.yml
Increased run.timeout from 10m to 15m; removed a trailing space in linters.enable (whitespace-only). No logic changes.

Sequence Diagram(s)

(omitted — changes do not affect control flow or introduce new runtime interactions)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled the hash beneath the moon,
Swapped a string, hums a gentle tune.
Linter waits a quarter more,
Builds hop onward from the door.
(\_/) (•ᴗ•) />🍃


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 37f8480 and c0fdb92.

📒 Files selected for processing (2)
  • .golangci.yml (2 hunks)
  • oci/Containerfile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • oci/Containerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build (macOS-latest, 1.20)
  • GitHub Check: build (ubuntu-latest, 1.20)
  • GitHub Check: build-and-push-image
🔇 Additional comments (2)
.golangci.yml (2)

11-11: LGTM on linter list normalization.

No functional change; retaining unused alongside goimports/gofmt is fine for this repo.


2-2: CI workflows have no step-level timeouts set—default 360 min job timeout covers the 15 min linter timeout.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
oci/Containerfile (1)

15-15: Let Renovate track this base image digest automatically

Add a Renovate hint so future digest rotations are auto-raised like the others in this file.

- FROM quay.io/centos/centos:stream9@sha256:a2ef206db47cea339ec3b6b0f3b5f4ebf2b6888a4a62746c4c5978bdfe015b32
+ # renovate: datasource=docker depName=quay.io/centos/centos versioning=docker
+ FROM quay.io/centos/centos:stream9@sha256:a2ef206db47cea339ec3b6b0f3b5f4ebf2b6888a4a62746c4c5978bdfe015b32
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9da7add and 37f8480.

📒 Files selected for processing (1)
  • oci/Containerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build (macOS-latest, 1.20)
  • GitHub Check: build (ubuntu-latest, 1.20)
  • GitHub Check: build-and-push-image
🔇 Additional comments (2)
oci/Containerfile (2)

15-15: Digest bump to CentOS Stream 9 — LGTM

Pinning to the new digest resolves the broken pull while keeping builds reproducible. No other concerns with this change.


15-15: Install skopeo or docker/podman and re-run the manifest and package verification

OCI/Containerfile (line 15)

  • Verify the digest resolves to the intended manifest type (index vs. single-arch).
  • Confirm that qemu-img and python3 install successfully and report the expected versions.

Previous sha checksum is not available anymore.
Also increase time to 15 minutes, due it gets timeout on
MacOS test.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@praveenkumar praveenkumar merged commit ae97705 into crc-org:main Sep 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants