Walkthrough

Reorganized DNS configuration tasks in an Ansible playbook by moving NetworkManager DNS-disabling logic to the top and adding explicit /etc/resolv.conf file state management, with conditional NetworkManager restart based on configuration changes.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Playbook
    participant NM as NetworkManager Config
    participant Service as NetworkManager Service
    participant File as resolv.conf File

    Playbook->>NM: Write NM conf to disable DNS overwrite
    Note over Playbook: Register _disable_dns_overwrite
    alt _disable_dns_overwrite.changed
        Playbook->>Service: Restart NetworkManager
    end
    Playbook->>File: Ensure regular file with proper permissions
    Note over Playbook: Continue with dnsmasq config

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single file with straightforward task reorganization and consolidation
• Conditional logic based on registration is standard Ansible pattern
• No complex dependencies or multi-step interactions introduced
• Primary focus: verify task order correctness and idempotency of the reorganized workflow

Poem

🐰 The tasks hop into place, DNS now set right,
No more NetworkManager writes—resolv.conf's tight!
We bundled the logic, moved chaos above,
Where dnsmasq awaits with files it shall love. 🔧✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Just in case, please wait for merging until Monday. Thank you