Skip to content

Increase timeout to 20m for golangci #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gbraad merged 1 commit into from
May 26, 2025
Merged

Increase timeout to 20m for golangci #202

gbraad merged 1 commit into from
May 26, 2025

Conversation

@danpawlik
Copy link
Collaborator

@danpawlik danpawlik commented May 22, 2025 •
edited by sourcery-ai bot
Loading

The CI jobs receive timeout on executing job.
Let's increase it to 20m.

Summary by Sourcery

CI:

  • Extend golangci-lint timeout to 20 minutes in vendored configs

@sourcery-ai
Copy link

sourcery-ai bot commented May 22, 2025 •
edited
Loading

Reviewer's Guide

Updated vendored GolangCI configuration files to increase the CI job timeout to 20 minutes.

File-Level Changes

Change Details Files
Extended GolangCI linter timeout for CI jobs
  • Changed timeout value to 20m in the GolangCI config
 vendor/github.com/pulumi/esc/.golangci.yml
vendor/github.com/sagikazarmark/locafero/.golangci.yaml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed May 22, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @danpawlik - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@danpawlik
Increase timeout to 20m for golangci; update CentOS 9 stream checksum
b233b3b 
The CI jobs receive timeout on executing job.
Let's increase it to 20m.

Also updated CentOS 9 stream container sha256 checksum to build the
images in the CI.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@gbraad gbraad merged commit c631aba into crc-org:main May 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@gbraad gbraad gbraad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danpawlik @gbraad