Skip to content

Change retries and delay time for cluster and resource verification #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
praveenkumar merged 1 commit into from
Sep 5, 2025
Merged

Change retries and delay time for cluster and resource verification #203

praveenkumar merged 1 commit into from
Sep 5, 2025

Conversation

@danpawlik
Copy link
Collaborator

@danpawlik danpawlik commented Sep 5, 2025 •
edited by coderabbitai bot
Loading

On crowded instances, where crc-cloud is used as CI job,
sometimes 20 retries (where delay is 5 seconds) might not be enough.
Incease the value to 20 and change delay time to 15 seconds.

Summary by CodeRabbit

  • Chores

    • Increased wait and retry intervals from 5s to 15s during deployment and cluster setup resource checks.

  • Impact

    • Enhances reliability in slower or transiently unstable environments by reducing false failures during provisioning.
    • May slightly extend overall wait time before a failure is reported.

@coderabbitai
Copy link

coderabbitai bot commented Sep 5, 2025 •
edited
Loading

Walkthrough

Increased wait/retry timing parameters across Ansible role defaults and a cluster setup script. Specifically, default wait_interval and retry_delay were raised, and the sleep duration inside a retry loop was extended. No logic, flow, or signatures were changed.

Changes

Cohort / File(s) Summary of Changes
Ansible wait/retry defaults
ansible/roles/deploy-crc-cloud/defaults/main.yaml		 Increased wait_interval from 5 to 15 and retry_delay from 5 to 15.
Cluster setup retry sleep
pkg/bundle/setup/clustersetup.sh		 In wait_for_resource, increased sleep between retries from 5s to 15s; max retries and control flow unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I tap my paw and learn to wait,
From five to fifteen—such patient fate.
The loops still turn, the scripts still keep,
We simply stretch our gentle sleep.
In burrows deep, I time my hop—
Retry, retry… then carrot-stop. 🥕⏳

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 828d6dd and ddf5a25.

📒 Files selected for processing (2)
  • ansible/roles/deploy-crc-cloud/defaults/main.yaml (1 hunks)
  • pkg/bundle/setup/clustersetup.sh (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • pkg/bundle/setup/clustersetup.sh
  • ansible/roles/deploy-crc-cloud/defaults/main.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build (macOS-latest, 1.20)
  • GitHub Check: build (ubuntu-latest, 1.20)
  • GitHub Check: build-and-push-image
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@danpawlik danpawlik force-pushed the increase-healthcheck-retries branch from 828d6dd to 6b37d36 Compare September 5, 2025 07:53
@danpawlik danpawlik changed the title Increase max retries from 20 to 60 Change retries and delay time for cluser and resource verification Sep 5, 2025
@danpawlik danpawlik force-pushed the increase-healthcheck-retries branch from 6b37d36 to a1e7d17 Compare September 5, 2025 07:54
@danpawlik danpawlik changed the title Change retries and delay time for cluser and resource verification Change retries and delay time for cluster and resource verification Sep 5, 2025
sdatko
sdatko approved these changes Sep 5, 2025
View reviewed changes
Copy link

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our discussion the commit message & description do not match the change now, but overall I just wanted to say I am in favor of this right now – there is no point in checking too often, while we can wait a little longer if in the end what we get is stable and usable environment.

@danpawlik
Change retries and delay time for cluster and resource verification
ddf5a25 
On crowded instances, where crc-cloud is used as CI job,
sometimes 20 retries (where delay is 5 seconds) might not be enough.
Incease the value to 20 and change delay time to 15 seconds.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik force-pushed the increase-healthcheck-retries branch from a1e7d17 to ddf5a25 Compare September 5, 2025 09:20
@praveenkumar praveenkumar merged commit cf93caa into crc-org:main Sep 5, 2025
4 checks passed
@danpawlik danpawlik deleted the increase-healthcheck-retries branch September 5, 2025 11:12
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sdatko sdatko sdatko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danpawlik @sdatko @praveenkumar