Update default cni network config in readme #8738
Conversation
Is this line correct? ``` By default, we install the dual stack version: 10-crio-bridge.conflist ``` To reproduce on new ubunty system(I used mutlipass on mac): ``` sudo -i # Ubuntu 24.04.1 LTS lsb_release -a # should be empty ls /etc | grep -ie 'cni\|crio' CRIO_VERSION=v1.31 curl -fsSL https://pkgs.k8s.io/addons:/cri-o:/stable:/$CRIO_VERSION/deb/Release.key | gpg --dearmor -o /etc/apt/keyrings/cri-o-apt-keyring.gpg echo "deb [signed-by=/etc/apt/keyrings/cri-o-apt-keyring.gpg] https://pkgs.k8s.io/addons:/cri-o:/stable:/$CRIO_VERSION/deb/ /" | tee /etc/apt/sources.list.d/cri-o.list apt-get update -y -qq apt-get install -y -qq cri-o systemctl start crio.service # should show cni and crio ls /etc | grep -ie 'cni\|crio' ``` What I see is 11-crio-ipv4-bridge.conflist by default: ``` ls /etc/cni/net.d/ 11-crio-ipv4-bridge.conflist ``` Signed-off-by: Shakir <30622440+networkandcode@users.noreply.github.com>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: networkandcode The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @networkandcode. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| ``` | ||
|
|
||
| By default, we install the dual stack version: [10-crio-bridge.conflist][dual-stack] | ||
| By default, we install the IPv4 only version: [11-crio-ipv4-bridge.conflist][ipv4-only] |
There was a problem hiding this comment.
@cri-o/cri-o-maintainers would it be better to install the dual stack config per default in the packages?
See: cri-o/packaging#197
There was a problem hiding this comment.
yeah I think installing the dual stack one in the packaging would be better
There was a problem hiding this comment.
yeah I think installing the dual stack one in the packaging would be better
Then let's close this PR.
|
Thank you for the PR @networkandcode! 🙏 We decided to change the default CNI configuration to use the dual stack, so I assume we can close this PR. /close |
|
@saschagrunert: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is this line correct?
To reproduce on new ubunty system(I used mutlipass on mac):
What I see is 11-crio-ipv4-bridge.conflist by default:
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?