[release-1.33] Backport kata logrotate fix #9452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the ReopenContainerLog function. This fixes an issue where kata container logs could not be rotated. This required duplicating part of the createContainerIO function, so I am moving this in its own subfunction for reuse. Signed-off-by: Julien Ropé <jrope@redhat.com>
This commit adds a test that simulates log rotation, making sure that the log file can be re-opened and used as expected. Signed-off-by: Julien Ropé <jrope@redhat.com>
saschagrunert
approved these changes
Sep 4, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: littlejawa, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-1.33 #9452 +/- ##
================================================
- Coverage 47.95% 47.90% -0.05%
================================================
Files 164 164
Lines 24180 24204 +24
================================================
Hits 11596 11596
- Misses 11439 11463 +24
Partials 1145 1145 🚀 New features to boost your workflow:
|
4d2f569
into
cri-o:release-1.33
53 of 55 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This is a cherry-pick of #9433
This commit implements the ReopenContainerLog function. This fixes an issue where kata container logs could not be rotated.
This required duplicating part of the createContainerIO function, so I am moving this in its own subfunction for reuse.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?