-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Migrate to container-libs #9460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3640329 to
78625f8
Compare
|
@cri-o/cri-o-maintainers PTAL |
78625f8 to
82202af
Compare
|
/hold just checking the version of podman we'd need to sync to to do this real quick |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9460 +/- ##
==========================================
- Coverage 67.02% 66.99% -0.03%
==========================================
Files 202 202
Lines 28196 28196
==========================================
- Hits 18897 18890 -7
- Misses 7707 7716 +9
+ Partials 1592 1590 -2 🚀 New features to boost your workflow:
|
82202af to
481613a
Compare
|
Rebased. |
481613a to
8504de2
Compare
|
Rebased. Can we get this in now @cri-o/cri-o-maintainers ? |
|
/test ci-cgroupv2-integration |
|
/retest @cri-o/cri-o-maintainers PTAL |
|
Merging this in 1.35 should be good, but want @haircommander to double check. |
|
We'll wait for podman 5.7 release, which should be happening in about a week. |
`c/{common,image,storage}` have been migrated to c/container-libs, which
we adapt.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
8504de2 to
b34e997
Compare
|
/retest |
|
@saschagrunert: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
c/{common,image,storage}have been migrated to c/container-libs, which we adapt.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?