[release-1.34] Backport credential provider support #9512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
We now move the namespaced auth files to a unique location for singular usage. This means that CRI-O can also remove the file afterwards, while other parallel pulls can re-use the previous file location for parallel pulls. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
951a6e7 to
942f649
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-1.34 #9512 +/- ##
=============================================
Coverage 67.03% 67.04%
=============================================
Files 202 202
Lines 28085 28144 +59
=============================================
+ Hits 18827 18868 +41
- Misses 7683 7690 +7
- Partials 1575 1586 +11 🚀 New features to boost your workflow:
|
Re-using the public auth and config API from the credential provider to keep both projects in sync. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
942f649 to
7dd254c
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
330c07f to
5a35fbc
Compare
Member
Author
|
@cri-o/cri-o-maintainers PTAL |
bitoku
reviewed
Oct 15, 2025
Contributor
bitoku
left a comment
There was a problem hiding this comment.
What is the version skew policy with cri-o and crio-credential-provider?
also can we wait for openshift/enhancements#1861 is approved?
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Member
Author
|
/test e2e-gcp-ovn |
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Member
Author
|
/test e2e-gcp-ovn |
Member
Author
|
@bitoku the enhancement got merged, can we continue with that PR? Even if we slip the API, we can still deliver the RPM and this functionality as a preview to users. |
Contributor
|
/retest |
c8e8b46
into
cri-o:release-1.34
66 of 68 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I'm going to downgrade the go 1.25 requirement in cri-o/crio-credential-provider#43
Does this PR introduce a user-facing change?