Skip to content

[release-1.32] OCPBUGS-63432: server: Fix network cleanup failures when NetNS path is empty #9617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 25, 2025
Merged

[release-1.32] OCPBUGS-63432: server: Fix network cleanup failures when NetNS path is empty #9617

openshift-merge-bot merged 1 commit into from
Nov 25, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 24, 2025

This is an automated cherry-pick of #9472

/assign haircommander

server: Fix network cleanup failures when NetNS path is empty

@sohankunkerkar
server: Fix network cleanup failures when NetNS path is empty
ede4cf7 
Fixes an issue where empty network namespace paths cause CNI teardown
failures, preventing pod deletion and creating stuck pods. This happens when
infra containers die, leaving NetNsPath() returning empty strings that CNI
plugins cannot handle.

The failure cascade: dead infra container → empty NetNS → CNI failure →
StopPodSandbox failure → stuck pod → systemd cgroup conflicts → new pod
creation failures. Observed in MicroShift environments.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 24, 2025
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 24, 2025
@openshift-ci openshift-ci bot requested review from klihub and littlejawa November 24, 2025 18:53
@haircommander haircommander changed the title [release-1.32] [OCPBUGS-58229]:server: Fix network cleanup failures when NetNS path is empty [release-1.32] [OCPBUGS-63432]:server: Fix network cleanup failures when NetNS path is empty Nov 24, 2025
@haircommander
Copy link
Member

haircommander commented Nov 24, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@haircommander: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander haircommander changed the title [release-1.32] [OCPBUGS-63432]:server: Fix network cleanup failures when NetNS path is empty [release-1.32] OCPBUGS-63432:server: Fix network cleanup failures when NetNS path is empty Nov 24, 2025
@haircommander haircommander changed the title [release-1.32] OCPBUGS-63432:server: Fix network cleanup failures when NetNS path is empty [release-1.32] OCPBUGS-63432: server: Fix network cleanup failures when NetNS path is empty Nov 24, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-63432, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-63432 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #9472

/assign haircommander

server: Fix network cleanup failures when NetNS path is empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member

haircommander commented Nov 24, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@haircommander: This pull request references Jira Issue OCPBUGS-63432, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-63432 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member

haircommander commented Nov 24, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2025

@haircommander: This pull request references Jira Issue OCPBUGS-63432, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-58229 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jogeo.

Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@haircommander: This pull request references Jira Issue OCPBUGS-63432, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-58229 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@haircommander
Copy link
Member

haircommander commented Nov 24, 2025

/cherry-pick release-1.31

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 24, 2025

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.31 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Nov 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (aadeb7d) to head (ede4cf7).
⚠️ Report is 2 commits behind head on release-1.32.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.32    #9617      +/-   ##
================================================
- Coverage         49.11%   48.85%   -0.27%     
================================================
  Files               155      155              
  Lines             17562    17570       +8     
================================================
- Hits               8626     8584      -42     
- Misses             7861     7917      +56     
+ Partials           1075     1069       -6
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haircommander
Copy link
Member

haircommander commented Nov 25, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e325ed0 into cri-o:release-1.32 Nov 25, 2025
39 of 49 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-63432: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-63432 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #9472

/assign haircommander

server: Fix network cleanup failures when NetNS path is empty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 25, 2025

@haircommander: #9617 failed to apply on top of branch "release-1.31":

Applying: server: Fix network cleanup failures when NetNS path is empty
Using index info to reconstruct a base tree...
M	server/sandbox_network.go
M	server/sandbox_stop_test.go
M	test/network.bats
Falling back to patching base and 3-way merge...
Auto-merging test/network.bats
Auto-merging server/sandbox_stop_test.go
Auto-merging server/sandbox_network.go
CONFLICT (content): Merge conflict in server/sandbox_network.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 server: Fix network cleanup failures when NetNS path is empty
Details

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@littlejawa littlejawa Awaiting requested review from littlejawa

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @haircommander @openshift-ci-robot @sohankunkerkar