Disable CNI configuration by default #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b9aae4 to
0867284
Compare
Member
Author
|
The get script CI should become green after this merges. |
kwilczynski
reviewed
Nov 29, 2024
kwilczynski
reviewed
Nov 29, 2024
Contributor
|
Nice. Simple and effective. |
Contributor
|
/approve |
We now disable the bridge CNI configuration and hint users how to still use it. Documentation has been updated with respect to that, too. Signed-off-by: Sascha Grunert <sgrunert@redhat.com> Co-authored-by: Krzysztof Wilczyński <kw@linux.com>
acf2d2e to
f4e9679
Compare
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We now disable the bridge CNI configuration and hint users how to still use it. Documentation has been updated with respect to that, too.
Which issue(s) this PR fixes:
Fixes #201
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?