Skip to content

Conversation

@bodji
Copy link
Collaborator

@bodji bodji commented Dec 19, 2025

Note: this is a vibe coded PR ;)

Copy link
Contributor

@damsallem damsallem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooooots of useless code generated ^^'.
Available for discussion

}
}

func TestOpenSearchEndpointConfigCustomValues(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is useless ^^'

}
}

func TestOpenSearchEndpointConfigEmptyYAML(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

}
}

func TestOpenSearchEndpointConfigPartialOverride(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

}

func TestOpenSearchProbeConfigStructure(t *testing.T) {
yamlStr := `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

"gopkg.in/yaml.v2"
)

func TestOpenSearchEndpointConfigDefaults(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless tests

}
}

func TestOpenSearchEndpointGetName(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless test

}
}

func TestOpenSearchEndpointConnect(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless tests, since it doesn't test a connection to an actual cluster isn't it ?

}
}

func TestOpenSearchEndpointRefresh(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless tests, no-op !

}
}

func TestOpenSearchEndpointClose(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing no-op, useless

}
}

func TestOpenSearchEndpointStructFields(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless test

@bodji bodji closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants