-
Notifications
You must be signed in to change notification settings - Fork 9
Add tests for OpenSearch probe #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
damsallem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loooooots of useless code generated ^^'.
Available for discussion
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointConfigCustomValues(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is useless ^^'
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointConfigEmptyYAML(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointConfigPartialOverride(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
| } | ||
|
|
||
| func TestOpenSearchProbeConfigStructure(t *testing.T) { | ||
| yamlStr := ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
| "gopkg.in/yaml.v2" | ||
| ) | ||
|
|
||
| func TestOpenSearchEndpointConfigDefaults(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useless tests
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointGetName(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless test
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointConnect(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless tests, since it doesn't test a connection to an actual cluster isn't it ?
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointRefresh(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless tests, no-op !
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointClose(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing no-op, useless
| } | ||
| } | ||
|
|
||
| func TestOpenSearchEndpointStructFields(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless test
Note: this is a vibe coded PR ;)