Enable install of .exe binaries in dtc package #2242
Conversation
Signed-off-by: Alex Tori <toriningen.me@gmail.com>
1ce3199 to
342c7f4
Compare
|
Maybe consider upstreaming this |
| + for bin in $(BIN); do \ | ||
| + if [ -f "$$bin" ]; then \ | ||
| + $(INSTALL_PROGRAM) $$bin $(DESTDIR)$(BINDIR); \ | ||
| + elif [ -f "$$bin.exe" ]; then \ |
There was a problem hiding this comment.
The way this is usually done would involve having a variable (e.g. EXEEXT) that is defined to nothing on Linux/BSD/etc and defined to .exe on msys/windows. Regardless see what you can land upstream first then ct-ng can carry a backport.
There was a problem hiding this comment.
The way this is usually done would involve having a variable (e.g.
EXEEXT) that is defined to nothing on Linux/BSD/etc and defined to.exeon msys/windows. Regardless see what you can land upstream first then ct-ng can carry a backport.
That's the route I wanted to go, but the challenge is that technically this is happening on Linux, we are cross-compiling for Windows, so uname won't match the extension.
I suppose it's configure's job to detect EXEEXT, but I can in theory do this in Makefile myself with something like this?
EXEEXT := $(shell echo | "$(CC)" -x c - '-###' -o foobar 2>&1 | \
sed -En '/-o foobar[^ ]*/s/.*-o foobar([^ ]*).*?/\1/p' | \
head -1)
Fixes #2241