Picolibc 1.8.10 #2335
Merged
Picolibc 1.8.10 #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpackham
reviewed
Apr 21, 2025
| config LIBC_PICOLIBC_REGISTER_FINI | ||
| bool | ||
| prompt "Enable finalization function registration using atexit" | ||
| prompt "Enable finalization function registration using atexit [unused]" |
Contributor
There was a problem hiding this comment.
Should we remove these in the next ct-ng release?
Contributor
Author
There was a problem hiding this comment.
I hesitated to remove them for fear of breaking existing configurations, but if that wouldn't cause any issues, then, yes, we should remove them. They've never been useful.
Contributor
There was a problem hiding this comment.
Yeah I think it's probably a good idea to keep them as no-op for now. Lets see if we can collectively remember to drop them after the next release :)
Picolibc 1.8.10 reworked the configuration option for single/multi thread support and removed some unused options for exit handler support. Map LIBC_PICOLIBC_MULTITHREAD to the new single-thread option or the old newlib-retargetable-locking+newlib-multithread options depending on whether the picolibc version knows about the single-thread option. Remove support for newlib-register-fini, newlib-atexit-dynamic-alloc, newlib-global-atexit and lite-exit options as all of those relate to the legacy exit handler code. There hasn't ever been any way to enable this using crosstool-ng, so none of these options have ever done anything. The help strings for each of of the unused configuration variables have been updated. Signed-off-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
04e4edc to
e120e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update picolibc to 1.8.10. This required re-working the mapping of CT options to picolibc meson options. That's done in the first patch in a fashion compatible with older picolibc and 1.8.10.