I want to value spacing at csstree 2.0.0 #173

Activity

1. lahmatiy commented on Dec 9, 2021

   

   lahmatiy

   on Dec 9, 2021

   Last edited by lahmatiy

   Member

   More actions

   The generator's mode: 'safe' exists because of IE11 ;)
   I didn't test much in IE11, so some fixes might be missed. I tested your examples, my results: border is broken, but box-shadow works well. Going to add whitespace between dimension and hash.
2. demonguyj commented on Dec 9, 2021

   

   demonguyj

   on Dec 9, 2021

   Author

   More actions

   Thanks for your check.
   But I found some cases.
   So I share for you.
   Thanks :)

   Expected

   background-position: 5% 90%, 10% 90%, 10% 90%, 15% 90%, 25% 90%, 25% 90%, 40% 90%, 55% 90%, 70% 90%;
   margin: 0 0 0 -15px;
   

   Result

   background-position: 5%90%, 10%90%, 10%90%, 15%90%, 25%90%, 25%90%, 40%90%, 55%90%, 70%90%;
   margin: 0 0 0-15px;
   
3. lahmatiy commented on Dec 9, 2021

   

   lahmatiy

   on Dec 9, 2021

   Member

   More actions

   All these cases are valid in IE11 (except border I mentioned before)
   
   Do you have different results?
4. demonguyj commented on Dec 9, 2021

   

   demonguyj

   on Dec 9, 2021

   Author

   More actions

   I have a same result too.
   I just check difference from before version.
   :)
5. lahmatiy commented on Dec 10, 2021

   

   lahmatiy

   on Dec 10, 2021

   Member

   More actions

   I added tests for this part (that's very complicated that's why I didn't it before). I also tested in IE11 and more cases are covered now. As a result, I fixed several issues in css-tree and one minor bug in spec :) So now this part is more stable.
6. lahmatiy commented on Dec 10, 2021

   

   lahmatiy

   on Dec 10, 2021

   Member

   More actions

   Fixes are released in 2.0.2
7. lahmatiy

   closed this as completedon Dec 10, 2021
8. demonguyj commented on Dec 15, 2021

   

   demonguyj

   on Dec 15, 2021

   Author

   More actions

   Unfortunately I still broken border. :(
   Check it please....

   expected

   border-bottom: 2px #f0f0f0 solid;
   

   result

   border-bottom: 2px#f0f0f0 solid;
   
9. lahmatiy commented on Dec 15, 2021

   

   lahmatiy

   on Dec 15, 2021

   Member

   More actions

   Do you use 2.0.3? I will check as well as will check for the tests to cover it
10. demonguyj commented on Dec 15, 2021

    

    demonguyj

    on Dec 15, 2021

    Author

    More actions

    I just tested csso 5.0.1.
    I knew csso 5.0.1 into csstree 2.0.3.
11. lahmatiy

    reopened this on Dec 17, 2021
12. lahmatiy commented on Dec 17, 2021

    

    lahmatiy

    on Dec 17, 2021

    Member

    More actions

    I found, that border parsing in IE11 is different from background which I used for testing. So 2px#f0f0f0 is ok for background but fails for border... I think adding a whitespace between dimension-token and hash-token should fix it.
13. lahmatiy

    closed this as completedin 17ff757on Dec 17, 2021
14. lahmatiy commented on Dec 17, 2021

    

    lahmatiy

    on Dec 17, 2021

    Member

    More actions

    Fixed in CSSTree 2.0.4 / CSSO 5.0.2