Refactor Integration tests #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… custom error response. Any testcase that uses custom error messages need to provide an enhanced error code.
…really supporting multi line SMTP responses
Collaborator
There was a problem hiding this comment.
Copilot reviewed 12 out of 21 changed files in this pull request and generated 1 comment.
Files not reviewed (9)
- integration/go.mod: Language not supported
- integration/tests/mail-from/custom.testcase: Language not supported
- integration/tests/milter/accept.testcase: Language not supported
- integration/tests/milter/multi.testcase: Language not supported
- integration/tests/milter/reject-one.testcase: Language not supported
- integration/tests/milter/reject.testcase: Language not supported
- integration/tests/rcpt-to/custom.testcase: Language not supported
- integration/tests/rcpt-to/multi.testcase: Language not supported
- integration/tests/rcpt-to/reject-one-2.testcase: Language not supported
typos Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the integration tests and workflows to improve functionality and documentation. The most important changes include adding a new
TestServerfunction, updating the integration test documentation, and modifying the workflow to install dependencies and update test configurations.Integration Test Enhancements:
integration/filter.go: Introduced a newTestServerfunction to facilitate testing ofmilter.Milterimplementations.integration/README.md: Expanded the documentation to include detailed instructions on how the integration test runner works, how to write test cases, and how to handle dynamic data. Added a mermaid diagram to visualize the test runner workflow. [1] [2] [3] [4] [5] [6] [7]Workflow Improvements:
.github/workflows/go.yml: Added a new step to install dependencies usinggo mod downloadand updated thego testcommand to use-covermode atomic. Also, specified files to ignore when sending coverage reports to Coveralls.Configuration Updates:
integration/runner/config.go: Removed hard-coded port configurations and introduced a dynamic port allocation mechanism usinggetAvailablePortto avoid port conflicts. [1] [2] [3] [4] [5] [6]Minor Changes:
integration/go.mod: Updated thegithub.com/d--j/go-milterdependency to versionv0.9.3.integration/mta/mock/mta.go: Fixed multi-line error messages in the mock MTA by escaping and un-escaping them appropriately.integration/runner/main.go: Adjusted logger prefixes for better readability.integration/runner/runner.go: RenamedprevDirtoactiveDirfor clarity in theRunmethod. [1] [2]