Skip to content

return exit code from exec_command() #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akvadrako wants to merge 1 commit into
base: master
Choose a base branch
from
Open

return exit code from exec_command() #66

akvadrako wants to merge 1 commit into from

Conversation

@akvadrako
Copy link

@akvadrako akvadrako commented Jun 29, 2016

I would like to check that my commands succeed from my calling script. This small change allows that to happen.

@aanand
Copy link
Collaborator

aanand commented Jun 29, 2016

This looks alright as a default. It adds another API call to exec_command, but people can always avoid that by using the lower-level ExecOperation interface.

LGTM

@TomasTomecek
Copy link
Contributor

TomasTomecek commented Jun 30, 2016

nicely done

looks like that SimpleQueue has different defintions on 2 and 3:

2

Init definition: SimpleQueue(self)

3

Init definition: SimpleQueue(self, *, ctx)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akvadrako @aanand @TomasTomecek