Skip to content

Conversation

@Tmonster
Copy link
Collaborator

requires duckdb/duckdb-avro#28
requires duckdb/duckdb#17698

By passing an extended open file info to the avro scan, we can pass validate_external_file_cache = false to the FileReader, which means we won't make unnecessary HEAD requests on secondary reads.

@Tmonster Tmonster requested a review from Tishj May 28, 2025 13:59
Copy link
Collaborator

@Tishj Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work 👍

"kind": "git",
"repository": "https://github.com/duckdb/vcpkg-duckdb-ports",
"baseline": "0f9bf648ba1ee29291890a1ca9a49a80bba017eb",
"baseline": "d3a5de6bd45b5907ed189054dd23eff6ec869e14",
Copy link
Collaborator

@Tishj Tishj Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reverting the registry version:
https://github.com/duckdb/vcpkg-duckdb-ports/commits/main/
0f9bf648ba1ee29291890a1ca9a49a80bba017eb - duckdb/vcpkg-duckdb-ports@0f9bf64
d3aa25a569e0eb35e01c59e3e62c9bc7406f0ed9 - duckdb/vcpkg-duckdb-ports@d3aa25a

This version is older than the one that's currently there, is there a reason for that?

I plan to bump this to add avro writes, I'd like to not run into any unrelated issues due to this PR causing issues with a newer patch version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see why this change is here, but I also don't think it matters, so we can merge it regardless

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commit is the most recent commit to vcpkg-duckdb-ports
d3a5de6bd45b5907ed189054dd23eff6ec869e14 I don't know where d3aa25 is coming from

@Tishj Tishj merged commit 8242b0f into duckdb:main Jun 4, 2025
17 of 18 checks passed
@Tmonster Tmonster deleted the set_extended_info_for_avro_reader branch July 25, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants