-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Remove Individual Vector Cardinalities #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove the individual vector cardinalities (
sel_vectorandcount). Instead, vectors have a reference to aVectorCardinalityobject that has their cardinality information.DataChunkinherits fromVectorCardinality, and vectors that live within a chunk all reference their parent chunk as their cardinality.This change removes a lot of duplicate information: in a chunk, all vectors are supposed to have the same count and selection vector. However, previously this was not enforced directly, but rather continuously checked using the
DataChunk::Verifymethod. Now, all the vectors within a DataChunk are enforced to have the same cardinality.This also means that the cardinality of individual vectors can no longer be set; instead the parent VectorCardinality must be modified. This also cleans up the ExpressionExecutor, as now the vectors that live in the expression executor all have the same cardinality, and there can no longer exist a function that (by accident) returns a vector with a different cardinality.
Vectors that have their own cardinality still exist: they are now called
FlatVector. This vector inherits from the regular Vector, but has its own VectorCardinality property. This is needed in surprisingly few places, however, and generally should not be used unless there is a good reason to use it.