Use Grapheme Cluster Breakers in Reverse and Shell #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clusters in a UTF8 string
…o correctly handle potential unicode modifier after an ascii char
…ectly render unicode characters
…atabase startup and changed through PRAGMA default_collation='x';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the reverse function to reverse based on grapheme clusters, which fixes issue #567. It also adds support of grapheme clusters to the duckdb_cli shell, which makes it behave a bit more logically w.r.t. unicode text (i.e. pressing "left" or "right" no longer goes left or right by one byte, but by one grapheme cluster, same with backspace/delete).