Case insensitive binding of column names #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e specifically constructed to have a case, this fixes #673
Contributor
|
This is fantastic! We will be providing DuckDB as a migration path from SQLite to our users, and this will greatly reduced the rework required! Will updating through Pip pull this change in? |
Contributor
|
I just saw the new release and that it included the Python package. Fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for case insensitive binding of column names, even when they are specifically constructed to have a case. The case insensitive binding only works if there are no conflicts, e.g. if a table has both the columns "Hello" and "HELLO", there is a conflict when trying to bind "hello", and as such the exact name must be specified. However, if the table only has the column "Hello", then "hello" has no conflict and will bind to it just fine.
This is a quality-of-life change that makes it easier to use column names with different casings, as previously any non-lowercase name had to be quoted to be used in SQL, i.e.
SELECT Hello FROM tabledoes not match the column "Hello". This now works, simplifying life somewhat. It also fixes the problems caused by #673.