Skip to content

Conversation

@Tishj
Copy link
Contributor

@Tishj Tishj commented Oct 12, 2023

This PR fixes #4812

Previously we would ignore any dictionaries in arrays that are not at the top level.

@Tishj
Copy link
Contributor Author

Tishj commented Oct 12, 2023

Just realized this does not have tests with big lists, which are likely going to fail
I'll add tests for this and throw NotImplementedExceptions for those cases

@github-actions github-actions bot marked this pull request as draft October 13, 2023 08:08
@Tishj Tishj marked this pull request as ready for review October 13, 2023 13:52
@github-actions github-actions bot marked this pull request as draft October 13, 2023 13:58
@Tishj
Copy link
Contributor Author

Tishj commented Oct 20, 2023

Depends on #9409

@Tishj Tishj marked this pull request as ready for review October 20, 2023 21:06
@Tishj Tishj requested a review from pdet October 21, 2023 12:27
@Mytherin Mytherin merged commit b0ad0c0 into duckdb:main Oct 24, 2023
@Mytherin
Copy link
Collaborator

Thanks!

@Tishj Tishj deleted the arrow_dictionary_in_child branch November 7, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested dictionary in Arrow integration

2 participants