Deserialize header fields #9687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
reviewed
Nov 15, 2023
Tishj
reviewed
Nov 15, 2023
12cd925 to
cc73f71
Compare
Contributor
Author
|
Thanks @Tishj! I had PR working on fork, then though of adding some last minute "improvements", that happened to be not really though through. |
1cc80c3 to
ffdb962
Compare
Note that this is not exposed in any way (yet) to the rest of the system, but this makes so that deserialization and serialization of header are now mirrored.
ffdb962 to
70accbd
Compare
Collaborator
|
Thanks |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 11, 2023
Merge pull request duckdb/duckdb#9687 from carlopi/storage_version Merge pull request duckdb/duckdb#9705 from hawkfish/icu-datediff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is not exposed in any way (yet) to the rest of the system, but this makes so that deserialization and serialization of header are now mirrored.