Internal #766: SkipList Coin Toss #9772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of rand/srand with pcg32_fast in the pool.
This also seems to improve performance by about 15%.
fixes: duckdblabs/duckdb-internal#766
Contributor
Author
|
Benchmark improvements: |
Contributor
|
More curiosity that anything, does it change something doing: _nodeRefs.push_back(this, _nodeRefs.height() ? 0 : 1);
uint32_t random_number = _pool.prng();
while (random_number % 2) {
_nodeRefs.push_back(this, _nodeRefs.height() ? 0 : 1);
random_number /= 2;
}This moves from expected 2 invocations of random generator per iteration to exactly 1 (assuming than depth > 32 are not relevant). |
Contributor
Author
|
It doesn't appear to have any noticeable effect. |
carlopi
approved these changes
Nov 23, 2023
Collaborator
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9772 from hawkfish/skiplist-rand Merge pull request duckdb/duckdb#9767 from samansmink/fix-vcpkg-patching-on-windows Merge pull request duckdb/duckdb#9757 from Tmonster/712-unicode-bugs Merge pull request duckdb/duckdb#9758 from samansmink/fix-issue-9727 Merge pull request duckdb/duckdb#9759 from samansmink/update-vcpkg-2023.10.19 Merge pull request duckdb/duckdb#9761 from samansmink/add-nightly-deploy-script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of rand/srand with pcg32_fast in the pool. This also seems to improve performance by about 15%.
fixes: duckdblabs/duckdb-internal#766