Skip to content

Conversation

@Tishj
Copy link
Contributor

@Tishj Tishj commented Feb 12, 2024

This PR fixes https://github.com/duckdblabs/duckdb-internal/issues/155

This should improve the error message that users gets when they are misusing a function that lives in an extension.
For example, the provided test:

statement error
FROM json("['item':'phasers','year':2155','count':1035]");
----
Catalog Error: Table Function with name "json" is not in the catalog, a function by this name exists in the json extension, but it's of a different type, namely Macro Function

I also took the opportunity to clean up the scripts/generate_extensions_function.py that we use to generate this file
It should be much more trivial and straightforward to extend this script to the other remaining catalog entries of extensions.

@github-actions github-actions bot marked this pull request as draft February 12, 2024 17:09
@Tishj Tishj requested a review from samansmink February 12, 2024 18:34
@Tishj Tishj marked this pull request as ready for review February 14, 2024 08:56
@github-actions github-actions bot marked this pull request as draft February 14, 2024 10:30
@Tishj Tishj marked this pull request as ready for review February 14, 2024 11:32
@github-actions github-actions bot marked this pull request as draft February 14, 2024 14:53
@Tishj Tishj marked this pull request as ready for review February 14, 2024 22:05
@github-actions github-actions bot marked this pull request as draft February 18, 2024 13:34
@Tishj Tishj marked this pull request as ready for review February 18, 2024 13:40
@Tishj
Copy link
Contributor Author

Tishj commented Feb 19, 2024

@Mytherin the regression test failure seems unrelated, not part of code touched by this PR, could you re-run it or can we ignore it?

It seems that the extension entries jobs still ran

@github-actions github-actions bot marked this pull request as draft February 21, 2024 14:45
@Tishj Tishj marked this pull request as ready for review February 24, 2024 12:30
@Mytherin Mytherin merged commit 4453541 into duckdb:main Feb 27, 2024
@Mytherin
Copy link
Collaborator

Thanks! LGTM - good idea to keep track of this

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Mar 15, 2024
Merge pull request duckdb/duckdb#10597 from Tishj/extension_function_type_listing
Merge pull request duckdb/duckdb#10859 from Tmonster/remove_sh_util_rm_dir
@Tishj Tishj deleted the extension_function_type_listing branch November 7, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants