Make unnamed_subquery naming predictable #10765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks how we name subqueries without aliases. Previously we used the table index we got from the binder, e.g.:
The problem is that this numbering is unstable and unpredictable. From the perspective of the user the name seems completely arbitrary, e.g.:
This causes problems also because queries are no longer portable, e.g. this query works:
But this fails:
This PR reworks the naming of unnamed subqueries so that they are predictable - they are named starting at
unnamed_subquery(without a number) - and then numbers are added as more unnamed subqueries are found within the same level of theFROMclause. For example:This also fixes an issue with using unnamed subqueries in the UNPIVOT, found here