BugFix: Introducing Introducing Delim Joins and Delim_Get(s) should respect positionally #11812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnkuiper
requested changes
Apr 29, 2024
Collaborator
lnkuiper
left a comment
There was a problem hiding this comment.
Looks good! Just two minor comments:
| ) | ||
| FROM all_types outer_alltypes GROUP BY ALL; | ||
|
|
||
| mode skip |
Collaborator
There was a problem hiding this comment.
Is the skip here intentional?
| // first check if the logical operator has correlated expressions | ||
| auto entry = has_correlated_expressions.find(*plan); | ||
| bool exit_projection = false; | ||
| unique_ptr<LogicalDelimGet> delim_scan = nullptr; |
Collaborator
There was a problem hiding this comment.
nitpick: unique_ptr is initialized to nullptr by default
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 5, 2024
Merge pull request duckdb/duckdb#11812 from Tmonster/delim_joins_and_reordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/duckdblabs/duckdb-internal/issues/1807
In queries where a correlated subquery requires a delim get, we want to preserve positionally of columns. Operators can get moved around and when operators get moved around the positionally of columns can change. This is especially bad when you have set operations, where positionally is important.
A delim_get is introduced with a cross product. The children of a cross product can be flipped around by the join order optimizer, affecting the positionally of the columns. With this fix, if a projecition wants to introduce a delim get, the delim get cross product is produced under it.