[Python] Fix issue related to the GIL when using execute with multiple statements
#13893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Fix duckdb/duckdb#13880: correctly name http_proxy_password setting (duckdb/duckdb#13890) [Python] Fix issue related to the GIL when using `execute` with multiple statements (duckdb/duckdb#13893)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 25, 2024
Fix duckdb/duckdb#13880: correctly name http_proxy_password setting (duckdb/duckdb#13890) [Python] Fix issue related to the GIL when using `execute` with multiple statements (duckdb/duckdb#13893) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13863
When multiple statements are provided to
con.execute, all the statements except the last one are "executed immediately", whereas the last statement goes through a slightly different path as prepared parameters might need to be injected before it gets executed.The
ExecuteImmediatelypath did not release the GIL before entering the bind+execution phase, which is what caused this error.