Fix Regression workflow running against itself#15165
Merged
Merged
Conversation
carlopi
approved these changes
Dec 6, 2024
Collaborator
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Add dictionary size, and use dictionary/constant vectors in the aggregate hash table to speed up finding groups (duckdb/duckdb#15152) Fix Regression workflow running against itself (duckdb/duckdb#15165) Fix wrongly used github.ref to sha (duckdb/duckdb#15167) Add cross-version testing CI (duckdb/duckdb#15161)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Add dictionary size, and use dictionary/constant vectors in the aggregate hash table to speed up finding groups (duckdb/duckdb#15152) Fix Regression workflow running against itself (duckdb/duckdb#15165) Fix wrongly used github.ref to sha (duckdb/duckdb#15167) Add cross-version testing CI (duckdb/duckdb#15161)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Add dictionary size, and use dictionary/constant vectors in the aggregate hash table to speed up finding groups (duckdb/duckdb#15152) Fix Regression workflow running against itself (duckdb/duckdb#15165) Fix wrongly used github.ref to sha (duckdb/duckdb#15167) Add cross-version testing CI (duckdb/duckdb#15161)
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 28, 2024
Add dictionary size, and use dictionary/constant vectors in the aggregate hash table to speed up finding groups (duckdb/duckdb#15152) Fix Regression workflow running against itself (duckdb/duckdb#15165) Fix wrongly used github.ref to sha (duckdb/duckdb#15167) Add cross-version testing CI (duckdb/duckdb#15161)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 28, 2024
Add dictionary size, and use dictionary/constant vectors in the aggregate hash table to speed up finding groups (duckdb/duckdb#15152) Fix Regression workflow running against itself (duckdb/duckdb#15165) Fix wrongly used github.ref to sha (duckdb/duckdb#15167) Add cross-version testing CI (duckdb/duckdb#15161) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed
--status=success, but this caused it to get the hash of the workflow currently in progress, which is always itself, as it was in progress ...Fixed by adding
--status=completed.