Add DictionaryId that can be used to uniquely identify dictionaries, and use this in the aggregate HT to cache look-ups#15196
Merged
Conversation
…and use this in the aggregate HT to cache look-ups
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Add DictionaryId that can be used to uniquely identify dictionaries, and use this in the aggregate HT to cache look-ups (duckdb/duckdb#15196)
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
Add DictionaryId that can be used to uniquely identify dictionaries, and use this in the aggregate HT to cache look-ups (duckdb/duckdb#15196)
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 28, 2024
Add DictionaryId that can be used to uniquely identify dictionaries, and use this in the aggregate HT to cache look-ups (duckdb/duckdb#15196)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 28, 2024
Add DictionaryId that can be used to uniquely identify dictionaries, and use this in the aggregate HT to cache look-ups (duckdb/duckdb#15196) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #15152
This PR enables the caching of results computed for dictionaries across vectors by (optionally) assigning them with a unique identifier. The identifier is a string that needs to be unique so we can distinguish between a vector having the same dictionary or a different dictionary as the previous vector. It does not have to be globally unique (i.e. really only in the same pipeline for the same thread).
ColumnSegmentpointer address. Since we never de-allocateColumnSegmentswhile scanning this works[parquet_filename]_[column_name]_[byte_offset]