[Upsert] Fix use of RETURNING in combination with UPSERT (ON CONFLICT DO ...) #15977
+118
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the return_collection
Mytherin
added a commit
that referenced
this pull request
Feb 4, 2025
With #15977, these changes should fix the remaining index-related nightly test failures. Fix duckdblabs/duckdb-internal#4095. Fix duckdblabs/duckdb-internal#4093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15791
This branch is made from #15927 as both of them touch the same code and needed partially the same changes.
The RETURNING result is now properly made to include each insert/update that gets made, instead of the optimistic approach that was taken before.