[Dev] MultiFileReader fix InternalError in CreateFilterMap #16114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! Can you rebase this to |
Contributor
|
Thanks, we found the same fix, though still get the error when filtering a Delta table by filename: select * from delta_scan('delta-examples/data/people_countries_delta_dask/', filename = True) where filename = 'delta-examples/data/people_countries_delta_dask/country=Argentina/part-00000-8d0390a3-f797-4265-b9c2-da1c941680a3.c000.snappy.parquet';though that might be a separate issue |
Collaborator
|
@marcoslot I can confirm that that issue still persists after this fix. I will take a look |
Collaborator
|
@marcoslot's issue is also present in DuckDB v1.1.3 meaning that it is separate issue. I will open an issue in the duckdb_delta repo for it |
samansmink
reviewed
Feb 7, 2025
Collaborator
samansmink
left a comment
There was a problem hiding this comment.
LGTM apart from the branch to merge into
23062e2 to
89daa84
Compare
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
[Dev] MultiFileReader fix InternalError in CreateFilterMap (duckdb/duckdb#16114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #16094
First this was using
global_columns, this list of columns is what the Reader is aware of, in this case the Parquet reader.This list is influenced by the
schemaparameter.global_column_idscomes from theTableFunctionInitInput, and will also contain artificial/generated columns like "filename"