PhysicalTableScan: Adapt to allow async behaviour #16310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped into this while looking to supporting some JavaScript async UDF functionality. Require a couple of other changes duckdb-wasm side, but it's viable path. I think this also makes sense in general for DuckDB, where an operator can now properly BLOCK and handle resuming on a side. This is at the moment an untested codepath in duckdb/duckdb CI.
e5c0303 to
c81d380
Compare
Tishj
reviewed
Feb 19, 2025
Tishj
reviewed
Feb 19, 2025
PR review comment from @Tishj
Contributor
|
As a test I think you want to make use of the The idea is that you force the function to block N number of times if that define is set |
Tishj
reviewed
Feb 20, 2025
Collaborator
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 7, 2025
PhysicalTableScan: Adapt to allow async behaviour (duckdb/duckdb#16310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped into this while looking to supporting JavaScript async UDF functionality in duckdb-wasm. This is the only duckdb/duckdb change, other fixes to be added on duckdb-wasm side, afterward it can be properly tested there.
I think this also makes sense in general for DuckDB, where an operator can now properly BLOCK and handle resuming on a side. This is particularly relevant for the poll path, expecially when single threaded (since no other work can happen otherwise).
This is at the moment an untested codepath in duckdb/duckdb CI, I need to add a test.