Fix: pyproject.toml does not contain a tool.setuptools_scm section #17443
Conversation
|
Thanks, if this works correctly now I'm fine with this, but I am still highly skeptical Change was introduced here #16739 When that PR was made, adding this section stopped the build from using the custom logic defined in the setup.py |
|
You should start a EDIT: I'm not sure of the steps required to enable github actions on your fork, so I've started a run on my own fork from your branch: |
|
@carlopi could you have a look at the runs I posted above? |
|
@Tishj: I checked the logs on your runs and looks all is behaving as expected (and test is indeed setup properly) |
Tishj
left a comment
There was a problem hiding this comment.
Thanks, seems the problem preventing this from working has been fixed upstream in setuptools_scm 👍
|
@Tishj: another candidate for "solving" this was maybe https://github.com/duckdb/duckdb/pull/17386/files with pinning the versions, unsure, but anyhow this can likely go in pending review. |
|
Thanks! |
Revert #17443 They have not fixed their problem, all they've done is upgrade the warning into an error, so we won't use those newer versions until they fix it 👍
[Fix] Macro binding with unknown parameters in list_has_all and some other code tidying (duckdb/duckdb#17450) Fix: pyproject.toml does not contain a tool.setuptools_scm section (duckdb/duckdb#17443)
[Fix] Macro binding with unknown parameters in list_has_all and some other code tidying (duckdb/duckdb#17450) Fix: pyproject.toml does not contain a tool.setuptools_scm section (duckdb/duckdb#17443)
[Fix] Macro binding with unknown parameters in list_has_all and some other code tidying (duckdb/duckdb#17450) Fix: pyproject.toml does not contain a tool.setuptools_scm section (duckdb/duckdb#17443)
Fix "pyproject.toml does not contain a tool.setuptools_scm section" by adding a minimal entry to pyproject.toml