Main branch versioning set to false #17602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2025
Contributor
|
This looks right, I will test it more properly and come back |
Mytherin
added a commit
that referenced
this pull request
May 22, 2025
minor restructure, allows for easier adjustment of default for MAIN_BRANCH_VERSIONING This PR is part of a 2 step code change: 1. minor resturcture, no logical change <----- **this PR** 2. set default for MAIN_BRANCH_VERSIONING to false (revert on main branch) #17602
carlopi
approved these changes
May 22, 2025
Contributor
carlopi
left a comment
There was a problem hiding this comment.
Thanks!
Tested, works as intended
Contributor
|
@Mytherin: this is good to go, and will make so that building v1.3-ossivalis branch will now get a version that looks like What's next:
Steps needs to happen in order, but lags in between are fine (no single atomic change :) ) |
Member
Author
|
also added to release checklist: |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 2, 2025
Generate correct UUID v7 (duckdb/duckdb#17612) Main branch versioning set to false (duckdb/duckdb#17602) minor restructure MAIN_BRANCH_VERSIONING (duckdb/duckdb#17601) [Dev][CLI] Use an unused bit for `DUCKDB_LATEST_STORAGE_VERSION` (duckdb/duckdb#17598)
Mytherin
added a commit
that referenced
this pull request
Sep 16, 2025
Toggle default value of `MAIN_BRANCH_VERSIONING` to false. see: #17602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default value for
MAIN_BRANCH_VERSIONINGto false.NOTE: needs to be reverted on main branch:
This PR is part of a 2 step code change: