Enable Test extension (inside docker) step in build_extensions_dockerized #17916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…always strings, so made it to be compared to the '1' string
…other string values
carlopi
approved these changes
Jun 13, 2025
Contributor
carlopi
left a comment
There was a problem hiding this comment.
Thanks a lot!
Probably there are other places where we do those wrongly typed comparisons, nice you have seen it.
Fixes will make so:
- tests will loadable extensions will be enabled also on LInux (currently they are skipped)
- builds for extensions will correctly use
save_cacheand other parameters.
Contributor
|
On your question on whether more tests would be problematic, tests are not performed on releases to avoid randomness introduced by networking errors or so, so that should not affect release. |
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 16, 2025
[chore] Skip 2 tests in autoloading mode (parquet + ZSTD) plus improve error message (duckdb/duckdb#17935) Enable Test extension (inside docker) step in build_extensions_dockerized (duckdb/duckdb#17916)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 16, 2025
[chore] Skip 2 tests in autoloading mode (parquet + ZSTD) plus improve error message (duckdb/duckdb#17935) Enable Test extension (inside docker) step in build_extensions_dockerized (duckdb/duckdb#17916) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement of the pr #17721 rebased with v1.3-ossivalis and added a fix of Save Cache step suggested by @carlopi
Copied from the original pr:
Test extension (inside docker)step couldn't run on Linux Extensions (x64) (linux_amd64, x64-linux). Most likely it go skipped because theinputs.run_testswas expecting a different input, but got default boolean value 1 in it'sif:condition:duckdb/.github/actions/build_extensions_dockerized/action.yml
Line 7 in 05acd1e
and later uses it like this:
duckdb/.github/actions/build_extensions_dockerized/action.yml
Line 101 in 05acd1e
LinuxRelease.ymlpasses a valuetruewhich is not evaluated by GH Actions as a boolean value, but as a string:duckdb/.github/workflows/LinuxRelease.yml
Line 153 in 05acd1e
This PR changes the condition to run tests and also enables
LOAD_TESTSforawsandiceberg