Skip to content

Resolve some small build issues #18162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mytherin merged 2 commits into from
Jul 7, 2025
Merged

Resolve some small build issues #18162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bb443f
Makefile: Ensure both sides of ifeq/ifneq use the same quotes
madscientist Jul 6, 2025
5c094f3
CMakeLists.txt: Use the target file to invoke duckdb_platform_binary
madscientist Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,7 +1513,7 @@ if(NOT DUCKDB_EXPLICIT_PLATFORM)
add_custom_command(
OUTPUT ${PROJECT_BINARY_DIR}/duckdb_platform_out
DEPENDS duckdb_platform_binary
COMMAND duckdb_platform_binary > ${PROJECT_BINARY_DIR}/duckdb_platform_out || ( echo "Provide explicit DUCKDB_PLATFORM=your_target_arch to avoid build-type detection of the platform" && exit 1 )
COMMAND $<TARGET_FILE:duckdb_platform_binary> > ${PROJECT_BINARY_DIR}/duckdb_platform_out || ( echo "Provide explicit DUCKDB_PLATFORM=your_target_arch to avoid build-type detection of the platform" && exit 1 )
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
)
else()
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ endif
ifeq (${GENERATE_EXTENSION_ENTRIES}, 1)
CMAKE_VARS:=${CMAKE_VARS} -DGENERATE_EXTENSION_ENTRIES=1
endif
ifneq (${ENABLE_EXTENSION_AUTOLOADING}, "")
ifneq ("${ENABLE_EXTENSION_AUTOLOADING}", "")
CMAKE_VARS:=${CMAKE_VARS} -DENABLE_EXTENSION_AUTOLOADING=${ENABLE_EXTENSION_AUTOLOADING}
endif
ifneq (${ENABLE_EXTENSION_AUTOINSTALL}, "")
ifneq ("${ENABLE_EXTENSION_AUTOINSTALL}", "")
CMAKE_VARS:=${CMAKE_VARS} -DENABLE_EXTENSION_AUTOINSTALL=${ENABLE_EXTENSION_AUTOINSTALL}
endif
ifneq (${UNSAFE_NUMERIC_CAST}, )
Expand Down
Loading