Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
a4dce39
add missing hugeint to switch
Jul 1, 2025
73571b0
refactor extracting filter expressions for index scan
Jul 1, 2025
b298ba8
shared_ptr<HTTPUtil>& must be reached from FileOpener
carlopi Jul 1, 2025
64998bd
Add missing `INT128` to decimal Parquet reader switch (#18104)
Mytherin Jul 1, 2025
03a2ddf
shared_ptr<HTTPUtil>& must be reached from FileOpener (#18107)
Mytherin Jul 1, 2025
534f567
Cleanup on correct branch (1.3-ossivalis) instead of v1.2-histrionicus
carlopi Jul 1, 2025
b541bec
Add v1.3.2 to version_map.json and generate storage_info
ZuleykhaPavlichenkova-TomTom Jul 1, 2025
1ab52f4
Cleanup on correct branch (1.3-ossivalis) instead of v1.2-histrionicu…
Mytherin Jul 2, 2025
f590339
Refactor extracting expressions for dynamic index scans (#18095)
Mytherin Jul 2, 2025
e718d40
Absorb patch from https://github.com/duckdb/duckdb/pull/18107
carlopi Jul 2, 2025
b844381
Actually correctly skip building unnecessary extensions
carlopi Jul 2, 2025
98066e1
Add v1.3.2 to version_map.json and generate storage_info.cpp (#18112)
Mytherin Jul 2, 2025
ed1c598
CI: Actually correctly skip building unnecessary extensions (#18119)
Mytherin Jul 2, 2025
01b2cc7
Absorb patch from https://github.com/duckdb/duckdb/pull/18107 (#18114)
Mytherin Jul 2, 2025
ccba5de
fix issue #18124
Jul 3, 2025
d9964bd
throw internal exception on corrupted roaring bitmap offsets
taniabogatsch Jul 3, 2025
54a0102
Use _unsigned_ hugeint for compressed materialization strings (#18128)
Mytherin Jul 3, 2025
00bc79c
Fix for arrow.json production extension type
pdet Jul 3, 2025
ba5abdf
Allow .tsv as an accepted db file
pdet Jul 3, 2025
f017e44
Fixing CSV Fuzzer issues
pdet Jul 3, 2025
899948b
Remove repeated tests
pdet Jul 3, 2025
f3ac1b9
Tests fixaroo
pdet Jul 3, 2025
e379cfb
format
pdet Jul 3, 2025
59a35ee
Throw internal exception on corrupted roaring bitmap offsets (#18130)
Mytherin Jul 3, 2025
ca2b2c8
bump iceberg
Tishj Jul 3, 2025
6fa2a8a
bump avro
Tishj Jul 3, 2025
dc5dc2b
Allow .tsv as an accepted db file (#18133)
Mytherin Jul 3, 2025
4924731
Fixing CSV Fuzzer issues (#18134)
Mytherin Jul 3, 2025
50c933f
Uncomment accidental commented tests
pdet Jul 4, 2025
06cd84b
Remove irrelevant comment
carlopi Jul 4, 2025
06d499c
Bump registry baseline
carlopi Jul 4, 2025
107c5d0
Bump further avro & iceberg
carlopi Jul 4, 2025
52a0cce
Add iceberg_to_ducklake to extension_entries.hpp
carlopi Jul 4, 2025
108e091
Iceberg to 74f0b1d8f38
carlopi Jul 4, 2025
a9865a4
partially restore deprecated http logging settings
samansmink Jul 4, 2025
f99ebd0
internal exceptions
taniabogatsch Jul 4, 2025
e510378
bump iceberg
Tmonster Jul 4, 2025
6b0be2c
update sqlsmith and aws as well
Tmonster Jul 4, 2025
01bc4a7
Merge branch 'v1.3-ossivalis' into roaring
taniabogatsch Jul 4, 2025
09659b1
revert iceberg bump
Tmonster Jul 4, 2025
ecb0e44
include fixes
taniabogatsch Jul 4, 2025
0564560
fix whitespace
Tmonster Jul 4, 2025
8dce900
exclude setting from test
samansmink Jul 4, 2025
2afda3a
Bump iceberg for 1.3.2, from @Tishj, and bumping also httpfs (#18148)
Mytherin Jul 4, 2025
d985421
bump ducklake for v1.3.2.
c-herrewijn Jul 4, 2025
9f56dbc
Internal #5245: AsOf NLJ Comparisons
hawkfish Jul 5, 2025
bc9bd8f
Internal #5245: AsOf NLJ Comparisons (#18159)
Mytherin Jul 5, 2025
42f1667
Add internal exceptions to compression paths to prevent segmentation …
Mytherin Jul 5, 2025
a4595bc
Fix for arrow.json production extension type (#18132)
Mytherin Jul 5, 2025
b9b1e44
partially restore deprecated http logging settings (#18150)
Mytherin Jul 5, 2025
7d473fc
bump spatial
Maxxen Jul 5, 2025
e27ccc2
add box2d type
Maxxen Jul 5, 2025
d1a4f37
bump again, remove && operator
Maxxen Jul 6, 2025
2f84fd8
Bump for wasm fixes (excel and httpfs) and test fixes (iceberg)
carlopi Jul 6, 2025
4d47531
Bump for wasm fixes (excel and httpfs) and test fixes (iceberg) (#18167)
Mytherin Jul 7, 2025
8e92841
bump spatial (#18161)
Mytherin Jul 7, 2025
266bc30
Bump spatial again: include re-linkinng for handling global objects i…
carlopi Jul 7, 2025
b889deb
Bump sqlsmith and aws (#18155)
Mytherin Jul 7, 2025
7080681
re-generate extension_entries.hpp
c-herrewijn Jul 7, 2025
1ea1ee9
formatting fix
c-herrewijn Jul 7, 2025
0b83e5d
bump ducklake for v1.3.2. (#18156)
Mytherin Jul 7, 2025
9592335
Bump spatial again: include re-linking for handling global objects in…
Mytherin Jul 7, 2025
301114d
Merge remote-tracking branch 'origin/main' into merge-v1.3-ossivalis
carlopi Jul 8, 2025
2f6929c
Fixup extension entries
carlopi Jul 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build_extensions/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ runs:
run: |
echo "VCPKG_TOOLCHAIN_PATH=$VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake" >> $GITHUB_ENV
echo "VCPKG_TARGET_TRIPLET=${{ inputs.vcpkg_target_triplet }}" >> $GITHUB_ENV
echo "BUILD_COMPLETE_EXTENSION_SET=${{ inputs.build_complete_extensions_set }}" >> docker_env.txt
echo "BUILD_COMPLETE_EXTENSION_SET=${{ inputs.build_complete_extensions_set }}" >> $GITHUB_ENV

- name: workaround for https://github.com/duckdb/duckdb/issues/8360
if: inputs.vcpkg_target_triplet == 'x64-windows-static-md'
Expand Down
4 changes: 2 additions & 2 deletions .github/config/out_of_tree_extensions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ duckdb_extension_load(httpfs
INCLUDE_DIR extension/httpfs/include
)

################# AVRO
################## AVRO
if (NOT MINGW)
duckdb_extension_load(avro
APPLY_PATCHES
Expand Down Expand Up @@ -74,7 +74,7 @@ duckdb_extension_load(excel
APPLY_PATCHES
LOAD_TESTS
GIT_URL https://github.com/duckdb/duckdb-excel
GIT_TAG 7e97933214d0c7de2315668ec68589ae85651afb
GIT_TAG cf00672f2d16685d9aefcca48c6a04d8c37d7015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we intentionally going to a different commit here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also marginal, expecially since it needs to be reworked/reviewed completely.
But the diff: duckdb/duckdb-excel@7e97933...cf00672 is not on the code side, so it's irrelevant.

INCLUDE_DIR src/excel/include
)

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -391,10 +391,10 @@ jobs:
./scripts/upload-assets-to-staging.sh twine_upload tools/pythonpkg/wheelhouse/*.whl

linux-release-cleanup:
if: github.ref == 'refs/heads/v1.3-ossivalis' || github.ref == 'refs/heads/main'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, my PR does not have this change, should it be included?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

name: PyPi Release Cleanup
needs:
- twine-upload
if: ${{ github.ref == 'refs/heads/v1.2-histrionicus' || github.ref == 'refs/heads/main' }}
runs-on: ubuntu-22.04
env:
PYPI_CLEANUP_USERNAME: 'mytherin'
Expand Down
25 changes: 25 additions & 0 deletions data/csv/afl/5194/crashes/case_0.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
a,b,c
1,1,1
1,1,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,\n,1
1,1000;"aa ""
;a ""
10"\n,1
1,\n,1
1,1,1
1,1,1
Binary file added data/csv/afl/5194/crashes/case_4.csv
Binary file not shown.
2 changes: 2 additions & 0 deletions extension/parquet/column_reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,8 @@ unique_ptr<ColumnReader> CreateDecimalReader(ParquetReader &reader, const Parque
return make_uniq<TemplatedColumnReader<int32_t, TemplatedParquetValueConversion<T>>>(reader, schema);
case PhysicalType::INT64:
return make_uniq<TemplatedColumnReader<int64_t, TemplatedParquetValueConversion<T>>>(reader, schema);
case PhysicalType::INT128:
return make_uniq<TemplatedColumnReader<hugeint_t, TemplatedParquetValueConversion<T>>>(reader, schema);
default:
throw NotImplementedException("Unimplemented internal type for CreateDecimalReader");
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/merge_vcpkg_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def prefix_overlay_port(overlay_port):
else:
data['vcpkg-configuration'] = {}

REGISTRY_BASELINE = '9989b8b4707261ce77425ae5364b7de7139a2030'
REGISTRY_BASELINE = '02558971ebafdbaa697a0704a3ed7ba365cd5495'
# NOTE: use 'scripts/list_vcpkg_registry_packages.py --baseline <baseline>' to generate the list of packages
data['vcpkg-configuration']['registries'] = [
{
Expand Down
2 changes: 1 addition & 1 deletion src/common/arrow/arrow_type_extension.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ void ArrowTypeExtensionSet::Initialize(const DBConfig &config) {

// Types that are 1:n
config.RegisterArrowExtension({"arrow.json", &ArrowJson::PopulateSchema, &ArrowJson::GetType,
make_shared_ptr<ArrowTypeExtensionData>(LogicalType::VARCHAR)});
make_shared_ptr<ArrowTypeExtensionData>(LogicalType::JSON())});

config.RegisterArrowExtension({"DuckDB", "bit", &ArrowBit::PopulateSchema, &ArrowBit::GetType,
make_shared_ptr<ArrowTypeExtensionData>(LogicalType::BIT), nullptr, nullptr});
Expand Down
10 changes: 6 additions & 4 deletions src/common/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,11 @@
},
{
"name": "enable_http_logging",
"description": "Enables HTTP logging",
"description": "(deprecated) Enables HTTP logging",
"type": "BOOLEAN",
"scope": "local",
"struct": "EnableHTTPLoggingSetting"
"struct": "EnableHTTPLoggingSetting",
"custom_implementation": true
},
{
"name": "enable_http_metadata_cache",
Expand Down Expand Up @@ -510,10 +511,11 @@
},
{
"name": "http_logging_output",
"description": "The file to which HTTP logging output should be saved, or empty to print to the terminal",
"description": "(deprecated) The file to which HTTP logging output should be saved, or empty to print to the terminal",
"type": "VARCHAR",
"scope": "local",
"struct": "HTTPLoggingOutputSetting"
"struct": "HTTPLoggingOutputSetting",
"custom_implementation": true
},
{
"name": "http_proxy",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ idx_t CSVIterator::BytesPerThread(const CSVReaderOptions &reader_options) {
// If we are setting up the buffer size directly, we must make sure each thread will read the full buffer.
return max_row_size;
}
if (bytes_per_thread == 0) {
// Bytes per thread can never be zero, but it might happen if max_row_size = 0
// Not sure why a human being would do that...
return 1;
}
return bytes_per_thread;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1373,7 +1373,7 @@ void StringValueScanner::ProcessOverBufferValue() {
result.escaped = true;
}
if (states.IsComment()) {
result.comment = true;
result.SetComment(result, j);
}
if (states.IsInvalid()) {
result.InvalidState(result);
Expand Down Expand Up @@ -1435,7 +1435,7 @@ void StringValueScanner::ProcessOverBufferValue() {
result.SetQuoted(result, j);
}
if (states.IsComment()) {
result.comment = true;
result.SetComment(result, j);
}
if (states.IsEscaped() && result.state_machine.dialect_options.state_machine_options.escape != '\0') {
result.escaped = true;
Expand Down
7 changes: 6 additions & 1 deletion src/execution/physical_plan/plan_asof_join.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,13 @@ PhysicalPlanGenerator::PlanAsOfLoopJoin(LogicalComparisonJoin &op, PhysicalOpera
asof_idx = i;
arg_min_max = "arg_min";
break;
default:
case ExpressionType::COMPARE_EQUAL:
case ExpressionType::COMPARE_NOTEQUAL:
case ExpressionType::COMPARE_DISTINCT_FROM:
break;
default:
// Unsupported NLJ comparison
return nullptr;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/function/function_list.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ static const StaticFunctionDefinition function[] = {
DUCKDB_SCALAR_FUNCTION_SET(InternalCompressIntegralUintegerFun),
DUCKDB_SCALAR_FUNCTION_SET(InternalCompressIntegralUsmallintFun),
DUCKDB_SCALAR_FUNCTION_SET(InternalCompressIntegralUtinyintFun),
DUCKDB_SCALAR_FUNCTION(InternalCompressStringHugeintFun),
DUCKDB_SCALAR_FUNCTION(InternalCompressStringUbigintFun),
DUCKDB_SCALAR_FUNCTION(InternalCompressStringUhugeintFun),
DUCKDB_SCALAR_FUNCTION(InternalCompressStringUintegerFun),
DUCKDB_SCALAR_FUNCTION(InternalCompressStringUsmallintFun),
DUCKDB_SCALAR_FUNCTION(InternalCompressStringUtinyintFun),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ static scalar_function_t GetStringCompressFunctionSwitch(const LogicalType &resu
return GetStringCompressFunction<uint32_t>(result_type);
case LogicalTypeId::UBIGINT:
return GetStringCompressFunction<uint64_t>(result_type);
case LogicalTypeId::HUGEINT:
return GetStringCompressFunction<hugeint_t>(result_type);
case LogicalTypeId::UHUGEINT:
return GetStringCompressFunction<uhugeint_t>(result_type);
default:
throw InternalException("Unexpected type in GetStringCompressFunctionSwitch");
}
Expand Down Expand Up @@ -189,8 +189,8 @@ static scalar_function_t GetStringDecompressFunctionSwitch(const LogicalType &in
return GetStringDecompressFunction<uint32_t>(input_type);
case LogicalTypeId::UBIGINT:
return GetStringDecompressFunction<uint64_t>(input_type);
case LogicalTypeId::HUGEINT:
return GetStringDecompressFunction<hugeint_t>(input_type);
case LogicalTypeId::UHUGEINT:
return GetStringDecompressFunction<uhugeint_t>(input_type);
default:
throw InternalException("Unexpected type in GetStringDecompressFunctionSwitch");
}
Expand Down Expand Up @@ -262,8 +262,8 @@ ScalarFunction InternalCompressStringUbigintFun::GetFunction() {
return CMStringCompressFun::GetFunction(LogicalType(LogicalTypeId::UBIGINT));
}

ScalarFunction InternalCompressStringHugeintFun::GetFunction() {
return CMStringCompressFun::GetFunction(LogicalType(LogicalTypeId::HUGEINT));
ScalarFunction InternalCompressStringUhugeintFun::GetFunction() {
return CMStringCompressFun::GetFunction(LogicalType(LogicalTypeId::UHUGEINT));
}

ScalarFunctionSet InternalDecompressStringFun::GetFunctions() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"type": "scalar_function"
},
{
"name": "__internal_compress_string_hugeint",
"name": "__internal_compress_string_uhugeint",
"parameters": "",
"description": "",
"example": "",
Expand Down
2 changes: 1 addition & 1 deletion src/function/scalar/compressed_materialization_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const vector<LogicalType> CMUtils::IntegralTypes() {

const vector<LogicalType> CMUtils::StringTypes() {
return {LogicalType::UTINYINT, LogicalType::USMALLINT, LogicalType::UINTEGER, LogicalType::UBIGINT,
LogicalType::HUGEINT};
LogicalType::UHUGEINT};
}

// LCOV_EXCL_START
Expand Down
Loading
Loading