Skip to content

[CI] Temporarily skip triggering R Package Windows (Extensions) job#18628

Merged
hannes merged 3 commits into
duckdb:v1.3-ossivalisfrom
ZuleykhaPavlichenkova-TomTom:skip-r
Aug 21, 2025
Merged

[CI] Temporarily skip triggering R Package Windows (Extensions) job#18628
hannes merged 3 commits into
duckdb:v1.3-ossivalisfrom
ZuleykhaPavlichenkova-TomTom:skip-r

Conversation

@ZuleykhaPavlichenkova-TomTom
Copy link
Copy Markdown
Contributor

[R / R Package Windows (Extensions) job had been failing 3 times at row.
Every time GH Action states that it lost communication with the runner, failed the job, but it keeps spinning.

I've opened an internal issue for this problem and think we should just skip triggering the job for now.

At the same time we don't have [R / R Package Windows (Extensions) job anymore in main. If we don't need it in v1.3-ossivalis maybe we should just back port those changes from main

@carlopi
Copy link
Copy Markdown
Member

carlopi commented Aug 16, 2025

I would assume the problem is encodings extensions taking excessive resources. I would think disabling that for R builds to be a better solution than skipping the whole job.

Copy link
Copy Markdown
Member

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(commented already, I think this is not the right angle)

@ZuleykhaPavlichenkova-TomTom
Copy link
Copy Markdown
Contributor Author

I would assume the problem is encodings extensions taking excessive resources. I would think disabling that for R builds to be a better solution than skipping the whole job.

Got it! That’d be more targeted solution

@duckdb-draftbot duckdb-draftbot marked this pull request as draft August 17, 2025 20:14
@ZuleykhaPavlichenkova-TomTom
Copy link
Copy Markdown
Contributor Author

@carlopi could you please take another look at the updates to this PR? Should work now, a test run is here

What I did:
1 - in OOT.cmake added a flag BUILD_ENCODINGS_EXTENSION because the BUILD_COMPLETE_EXTENSION_SET flag was set to true
2 - passed cmake_flags: "-DBUILD_ENCODINGS_EXTENSION=OFF" to the R.yml workflow so the encodings extention only is skipped.

@ZuleykhaPavlichenkova-TomTom ZuleykhaPavlichenkova-TomTom marked this pull request as ready for review August 17, 2025 22:30
@ZuleykhaPavlichenkova-TomTom
Copy link
Copy Markdown
Contributor Author

ZuleykhaPavlichenkova-TomTom commented Aug 19, 2025

@carlopi
The same problem appeared in Nightly extensions build in main tonight - extensions / Main Extensions / Build / Windows (windows_amd64_mingw, x64-mingw-static, x64-mingw-static)

Which caused the extensions not being uploaded

Comment thread .github/config/out_of_tree_extensions.cmake Outdated
Copy link
Copy Markdown
Member

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See commend, I would add a NOT MINGW and to .github/config/extensions/encodings and call it a day.

@ZuleykhaPavlichenkova-TomTom
Copy link
Copy Markdown
Contributor Author

ZuleykhaPavlichenkova-TomTom commented Aug 19, 2025

See commend, I would add a NOT MINGW and to .github/config/extensions/encodings and call it a day.

Thank you for the tip! I've opened another PR, now against main, for the changes in .github/config/extensions/encodings

@ZuleykhaPavlichenkova-TomTom ZuleykhaPavlichenkova-TomTom marked this pull request as ready for review August 19, 2025 11:20
Comment thread .github/workflows/InvokeCI.yml
@duckdb-draftbot duckdb-draftbot marked this pull request as draft August 19, 2025 13:31
@ZuleykhaPavlichenkova-TomTom ZuleykhaPavlichenkova-TomTom marked this pull request as ready for review August 19, 2025 13:42
Mytherin added a commit that referenced this pull request Aug 20, 2025
This PR is a temporary solution that makes `InvokeCI` skip building
`encodings` extension.

The problem: GH Actions looses connection with runner while building
`encodings` extension in [extensions / Main Extensions / Build / Windows
(windows_amd64_mingw, x64-mingw-static,
x64-mingw-static)](https://github.com/duckdb/duckdb/actions/runs/17056222844/job/48354362677)
job

Connected to #18628 against
`v1.3-ossivalis` where the same is happening in `[R / R Package Windows
(Extensions)` job.
@hannes hannes merged commit e2b0bef into duckdb:v1.3-ossivalis Aug 21, 2025
49 checks passed
github-actions Bot pushed a commit to duckdb/duckdb-r that referenced this pull request Aug 22, 2025
Move attached databases from a CatalogSet to a dedicated map of shared pointers (duckdb/duckdb#18693)
Unplug python (in ossivalis) (duckdb/duckdb#18699)
Using a different workflow to release the python package (duckdb/duckdb#18685)
Add WAL test config run (duckdb/duckdb#18683)
[CI] Temporarily skip triggering `R Package Windows (Extensions)` job (duckdb/duckdb#18628)
Load pandas in import cache before binding (duckdb/duckdb#18658)
Remove `PRAGMA enable_verification` in more tests (duckdb/duckdb#18670)
Remove more `PRAGMA enable_verification` (duckdb/duckdb#18664)
Remove `PRAGMA enable_verification` (duckdb/duckdb#18645)
github-actions Bot added a commit to duckdb/duckdb-r that referenced this pull request Aug 22, 2025
Move attached databases from a CatalogSet to a dedicated map of shared pointers (duckdb/duckdb#18693)
Unplug python (in ossivalis) (duckdb/duckdb#18699)
Using a different workflow to release the python package (duckdb/duckdb#18685)
Add WAL test config run (duckdb/duckdb#18683)
[CI] Temporarily skip triggering `R Package Windows (Extensions)` job (duckdb/duckdb#18628)
Load pandas in import cache before binding (duckdb/duckdb#18658)
Remove `PRAGMA enable_verification` in more tests (duckdb/duckdb#18670)
Remove more `PRAGMA enable_verification` (duckdb/duckdb#18664)
Remove `PRAGMA enable_verification` (duckdb/duckdb#18645)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants