WALReplay Fix: In UpdateColumn, no longer assume all updates are part of the same vector, but instead verify this and batch updates per vector#18999
Merged
Conversation
…ctor, but instead verify this and batch updates per vector
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 15, 2025
WALReplay Fix: In UpdateColumn, no longer assume all updates are part of the same vector, but instead verify this and batch updates per vector (duckdb/duckdb#18999) ATTACH IF NOT EXISTS - wait until database is fully attached before returning (duckdb/duckdb#18993)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Sep 15, 2025
WALReplay Fix: In UpdateColumn, no longer assume all updates are part of the same vector, but instead verify this and batch updates per vector (duckdb/duckdb#18999) ATTACH IF NOT EXISTS - wait until database is fully attached before returning (duckdb/duckdb#18993) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #18829, it is easier for row groups to be less strictly aligned, and also for the same series of appends to not necessarily create the exact same row group layout.
The current implementation for update replay in the WAL requires row ids to be perfectly stable: it assumes that it can figure out based on the first row-id in the vector the vector that the rest of the updates belong to. This PR reworks the
UpdateColumnmethod to instead figure out the correct vector that each of the row-ids in the update belongs to prior to performing the update. As a result, this code is robust to differences in row group layouts and the row-ids are no longer required to all be part of the same vector.