Destroy row groups in parallel#19053
Merged
Merged
Conversation
lnkuiper
reviewed
Sep 19, 2025
Member
lnkuiper
left a comment
There was a problem hiding this comment.
This looks good! I built this locally, and timed how long it takes to quit the CLI on my laptop after running TPC-H Q1 at SF1000, but the time was similar (4s vs 3.5s).
Is the speedup only expected on Linux, or only on machines with many more cores?
Collaborator
Author
|
On my machine with ATTACH 'hits.db';
.mode trash
FROM hits.hits; -- load entire db into memory
.timer on
DETACH hits;Old: New: |
Member
|
Thanks for sharing the |
lnkuiper
approved these changes
Sep 19, 2025
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Oct 21, 2025
Destroy row groups in parallel (duckdb/duckdb#19053)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Nov 1, 2025
Destroy row groups in parallel (duckdb/duckdb#19053)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Nov 2, 2025
Destroy row groups in parallel (duckdb/duckdb#19053)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shutting down or closing a database, we need to destroy all loaded row groups. For very large databases, we can have many row groups with many column data / column segments loaded. Relying on regular C++ destructors to destroy these results in a single-threaded pass over all this data. On many core machines, this can be significantly sped up by doing this in parallel.