Internal #5380: AsOf Join Pipeline #19169
Merged
Merged
Conversation
Member
hawkfish
commented
Sep 27, 2025
- Implement double pipeline breaker version
- Move join key filtering to GetData
- Handle all left join conditions
added 7 commits
September 25, 2025 14:14
* Checkpoint commit for double pipeline breaker version
* Fix left_group computation
* Fix is_outer initialisation
* Move join key filtering to GetData
* Handle all left join conditions
* Cleanup asymmetries
Member
Author
|
@lnkuiper figured you should look at this so you have some background for the eventual sorting rewrite? |
lnkuiper
reviewed
Sep 29, 2025
Member
lnkuiper
left a comment
There was a problem hiding this comment.
Thanks for the PR! I just have one concern:
* Make Finalize match the other double pipeline breaker (IEJoin) * Add test to be sure (it was fine without the change, but future proofing seems smart)
lnkuiper
approved these changes
Sep 30, 2025
Member
lnkuiper
left a comment
There was a problem hiding this comment.
Thanks for adding the test! LGTM now
Member
|
Thanks! |
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Oct 21, 2025
Internal duckdb/duckdb#5380: AsOf Join Pipeline (duckdb/duckdb#19169)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Nov 1, 2025
Internal duckdb/duckdb#5380: AsOf Join Pipeline (duckdb/duckdb#19169)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Nov 2, 2025
Internal duckdb/duckdb#5380: AsOf Join Pipeline (duckdb/duckdb#19169)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Nov 2, 2025
Internal duckdb/duckdb#5380: AsOf Join Pipeline (duckdb/duckdb#19169)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.