hugeint_t fixes #19318
Merged
hugeint_t fixes #19318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnkuiper
requested changes
Oct 9, 2025
Collaborator
lnkuiper
left a comment
There was a problem hiding this comment.
Could you have a look at the inet test failures? It relies on an implicit conversion
8e60773 to
42f22f0
Compare
lnkuiper
approved these changes
Oct 9, 2025
Collaborator
lnkuiper
left a comment
There was a problem hiding this comment.
Thanks for the changes! This is good to go once CI passes.
Thanks for looking into this bug in more detail. I'm happy the implicit conversion is gone now, this is a hazard
2 tasks
13 tasks
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
hugeint_t fixes (duckdb/duckdb#19318)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
hugeint_t fixes (duckdb/duckdb#19318) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Mytherin
added a commit
that referenced
this pull request
Dec 13, 2025
We used to use GCC 12 instead of the manylinux-default GCC 14 for compatibility reasons. This seems no longer required, and the GCC14 Arm bug with UUID has been resolved in #19318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three independent fixes I bumped against while looking at a funky bug that is compiler specific (in particular gcc 14):
const hugeint_t &instead of passing by valueThird commit in particular makes the bug go away, and even on it's own it can not justify the behaviour, was creating a weird situation where in an abundance of available templates overloads compilers are not forced to pick one. On this consensus on compiler implemented evolved (see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p3606r0.html), but we better stay away from grey areas where different compilers might (somewhat reasonably) take different decisions.
The third commit alone solves #17757, at least I did check the simplest reproduction, should be uncontroversial changes that arguably would make sense in any case, so maybe I would consider this for merging in
v1.4-andium.