Skip to content

Conversation

@pdet
Copy link
Collaborator

@pdet pdet commented Nov 12, 2025

This recently threw me off completely, so I’m adding a simple assertion here.

@pdet
Copy link
Collaborator Author

pdet commented Nov 14, 2025

So this test is failing because it encoutered mismatches in our code wrt the logger, mainly there is a fetch where the column data collector has a timestamp, but the result chunk has a timestamp_tz.
We could resolve this by checking the physical type instead of the logical type, but I wanted to verify if that's intentional first, cc @samansmink

@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 14, 2025 09:30
@samansmink
Copy link
Collaborator

@pdet Yea that's intentional I think, see #18768

@pdet
Copy link
Collaborator Author

pdet commented Nov 14, 2025

Alright, I think timestamp -> timestamp_tz is harmless since there is no data change in there, i'll add an exception to these logical types instead of going full in physical type. Thanks!

@pdet pdet marked this pull request as ready for review November 14, 2025 15:13
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 19, 2025 14:23
@pdet pdet marked this pull request as ready for review November 19, 2025 15:19
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 20, 2025 12:42
@pdet pdet marked this pull request as ready for review November 20, 2025 12:54
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 21, 2025 12:03
@pdet pdet marked this pull request as ready for review November 21, 2025 14:20
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 24, 2025 12:40
@pdet pdet marked this pull request as ready for review November 24, 2025 14:13
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 25, 2025 09:03
@pdet pdet marked this pull request as ready for review November 25, 2025 09:07
@pdet pdet merged commit 52b7324 into duckdb:v1.4-andium Nov 25, 2025
100 checks passed
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Nov 27, 2025
Assert that result types match with column data collection when fetching data (duckdb/duckdb#19750)
Script to release a extension manually (duckdb/duckdb#19881)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Nov 27, 2025
Assert that result types match with column data collection when fetching data (duckdb/duckdb#19750)
Script to release a extension manually (duckdb/duckdb#19881)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants