More testing for appender and attach-detach #19708
Merged
+200
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Contributor
Author
|
We should also ensure that we inspect the checkpoint error for the expected error. |
Collaborator
|
@taniabogatsch It seems like there is a memory leak for |
Contributor
Author
|
Yes, probably - I'll have a look! |
pdet
reviewed
Nov 18, 2025
Collaborator
pdet
left a comment
There was a problem hiding this comment.
Thanks for the PR @taniabogatsch, I just had a few questions/comments
Contributor
Author
|
@pdet thanks a lot for the questions / |
pdet
approved these changes
Nov 21, 2025
Collaborator
pdet
left a comment
There was a problem hiding this comment.
Thanks!
I think it looks great, I just had a few small nits, but I'll leave it to your discretion. IMO, looks good as is.
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 27, 2025
More testing for appender and attach-detach (duckdb/duckdb#19708) Make `make tidy-check-diff` compare against base branch, instead of always comparing against `origin/main` (duckdb/duckdb#19917) [Compression] Prevent overriding `COMPRESSION_EMPTY` with `COMPRESSION_CONSTANT` (duckdb/duckdb#19913) free disk space in Upload Extensions job (duckdb/duckdb#19912)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 27, 2025
More testing for appender and attach-detach (duckdb/duckdb#19708) Make `make tidy-check-diff` compare against base branch, instead of always comparing against `origin/main` (duckdb/duckdb#19917) [Compression] Prevent overriding `COMPRESSION_EMPTY` with `COMPRESSION_CONSTANT` (duckdb/duckdb#19913) free disk space in Upload Extensions job (duckdb/duckdb#19912) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.