[Parquet] Fix prepared copy option parameter #19966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if non-foldable expressions are given as copy option
Mytherin
reviewed
Nov 27, 2025
Collaborator
Mytherin
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good - one comment:
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 28, 2025
[Parquet] Fix prepared copy option parameter (duckdb/duckdb#19966) [chore] Increase slow threshold (duckdb/duckdb#19965)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 28, 2025
[Parquet] Fix prepared copy option parameter (duckdb/duckdb#19966) [chore] Increase slow threshold (duckdb/duckdb#19965) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #19884
I've added a check to see if the expression is foldable, otherwise it can't be used in EvaluateScalar.
If it's not foldable, we'll check if it has a parameter expression and throw ParameterNotResolved if that's the case, otherwise we throw a BinderException.