Skip to content

Windows must sample less #20018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mytherin merged 5 commits into from
Dec 3, 2025
Merged

Windows must sample less #20018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07f1fd1
require notwindows on the test to avoid nightly fails
Tmonster Dec 2, 2025
15b866d
fix test on windows
Tmonster Dec 2, 2025
15a1daa
require 16gb ram instead
Tmonster Dec 2, 2025
e04f3bc
remove windows specific limit
Tmonster Dec 3, 2025
9653797
Merge remote-tracking branch 'upstream/v1.4-andium' into fix_table_sa…
Tmonster Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/include/duckdb/common/allocator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ class AllocatedData {
};

class Allocator {
public:
// 281TB ought to be enough for anybody
static constexpr const idx_t MAXIMUM_ALLOC_SIZE = 281474976710656ULL;

Expand Down
2 changes: 2 additions & 0 deletions test/sql/sample/test_sample_too_big.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# description: Test SAMPLE keyword
# group: [sample]

require ram 16gb

statement ok
CREATE TABLE t1(a INT);

Expand Down
Loading