Issue #21592: Window Self-Join Framing#21628
Merged
Merged
Conversation
Member
hawkfish
commented
Mar 25, 2026
- Don't apply the optimisation for ROWS framing
* Don't apply the optimisation for ROWS framing
* Check plans, not unstable results.
Member
Author
|
The regression failure appears unrelated - the failing benchmark has no windowing. |
Member
|
Thanks! |
github-actions Bot
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Mar 26, 2026
Date: 2026-03-26 10:15:17 +0100 Issue duckdb/duckdb#21592: Window Self-Join Framing (duckdb/duckdb#21628) Fix duckdb/duckdb#21623: flatten input chunk in TopNHeap::CheckBoundaryValues (duckdb/duckdb#21629)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Mar 26, 2026
Date: 2026-03-26 10:15:17 +0100 Issue duckdb/duckdb#21592: Window Self-Join Framing (duckdb/duckdb#21628) Fix duckdb/duckdb#21623: flatten input chunk in TopNHeap::CheckBoundaryValues (duckdb/duckdb#21629)
github-actions Bot
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Mar 26, 2026
Date: 2026-03-26 10:15:17 +0100 Issue duckdb/duckdb#21592: Window Self-Join Framing (duckdb/duckdb#21628)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Mar 26, 2026
Date: 2026-03-26 10:15:17 +0100 Issue duckdb/duckdb#21592: Window Self-Join Framing (duckdb/duckdb#21628)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Mar 26, 2026
Date: 2026-03-26 10:15:17 +0100 Issue duckdb/duckdb#21592: Window Self-Join Framing (duckdb/duckdb#21628)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.