forked from h2oai/db-benchmark
-
Notifications
You must be signed in to change notification settings - Fork 40
Add new machine type (32GB memory / 16 cores) #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some requests to vary the machine type so that we can get a more accurate representation of how these solutions perform on varying amounts of resources. The new machine type is a dedicated c6id.4xlarge. Again mounted storage is used, and a dedicated instance is used to avoid noisy neighbors. This is equivalent to taking the bare-metal c6.metal machine and only using 1/8 of the resources.
I've been developing this PR for a while now, and I think it is almost ready to merge/publish results. It currently doesn't test all solutions across all variations of hardware as some solutions cannot deal with the more limited memory constraints for the smaller machine types. I plan on adding results for these solutions as time goes on. I hope solution maintainers can be patient with me.
Eventually I would also like to add c6id.8xlarge(32cores/64GB memory) and potentially c6id.2xlarge(8cores/16GBmemory) but that will be another project.